fix: skew protection #1658
Merged
fix: skew protection #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Playwright test results
Details
|
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! New Pages AddedThe following pages were added to the bundle from the code in this PR:
|
Playwright test results
Details
|
abvthecity
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
abvthecity
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
abvthecity
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
abvthecity
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
dsinghvi
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem 1: when you run
vercel buildthenvercel deploy --prebuilt, we don't actually get access to any of the vercel-specific environment variables, e.g.VERCEL_DEPLOYMENT_IDorVERCEL_ENVat built-time. So, we needed to switch the deployment model such that source files are uploaded to vercel so that vercel build the deployment directly.Problem 2: nextjs (perhaps because we're using a fork of nextjs?) is not correctly setting the x-deployment-id header in the prefetch requests. to circumvent this, we're appending
?dpl=${process.env.NEXT_DEPLOYMENT_ID}to all prefetch requests from the router. This will force skew protection on prefetching!Problem 3: all other fetch requests to
/api/fern-docs/*must have thex-deployment-idheader set to leverage skew protection. For some reason, nextjs is stripping away this header, so we are appending?dpl=instead.Side effect: nextjs bundle analyzer requires that the nextjs bundle is done locally. I've updated the gh action script to handle this.