-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fdr): add tags and PR links to releases data model #1489
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 7 Skipped Deployments
|
🌿 Preview your docs: https://fern-preview-52165ad5-cdb1-4ded-bcbe-a69fc6efca82.docs.buildwithfern.com |
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
- name: asyncapi | ||
value: "AsyncAPI" | ||
- name: grpc | ||
value: "gRPC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think there's any benefit of structuring here? my guess is string is fine and if we want to structure we just put all of that onus on the client (seed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, updated
docs: | | ||
The URL to the pull request that introduced this change. This is optional for backcompat. | ||
You do not always need to specify the URL as the CLI can fill it in with the current PR, but given you can choose to not | ||
release within the same PR as the change is introduced, this should be specified for divorcing the two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting how palantir does it, just posting as another data point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to links
🌿 Preview your docs: https://fern-preview-5ac8e466-1d8d-40fa-a77d-47c6d159480c.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-21cb0fc2-f755-4123-a925-1dbc4a645015.docs.buildwithfern.com |
Fixes FER-3255
Short description of the changes made
This PR adds the concept of a tag to the release itself, as well as PR links to the changelog entry items
What was the motivation & context behind this PR?
How has this PR been tested?
Some db ete tests