chore(fdr): update git datamodel to reflect github api

fern-api · Sep 17, 2024 · bc1504f · bc1504f
1 parent 2f616f7
commit bc1504f
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 11 deletions.
diff --git a/fern/apis/fdr/definition/git.yml b/fern/apis/fdr/definition/git.yml
@@ -69,8 +69,8 @@ types:
 
   GithubUser:
     properties:
-      name: string
-      email: string
+      name: optional<string>
+      email: optional<string>
       username: string
 
   GithubTeam:
@@ -95,7 +95,7 @@ types:
       pullRequestNumber: integer
       repositoryName: string
       repositoryOwner: string
-      author: GithubUser
+      author: optional<GithubUser>
       reviewers: list<PullRequestReviewer>
       title: string
       url: string

diff --git a/packages/fdr-sdk/src/client/generated/api/resources/git/types/GithubUser.ts b/packages/fdr-sdk/src/client/generated/api/resources/git/types/GithubUser.ts
diff --git a/packages/fdr-sdk/src/client/generated/api/resources/git/types/PullRequest.ts b/packages/fdr-sdk/src/client/generated/api/resources/git/types/PullRequest.ts
diff --git a/servers/fdr/prisma/migrations/20240917214830_make_pr_author_optional/migration.sql b/servers/fdr/prisma/migrations/20240917214830_make_pr_author_optional/migration.sql
@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "PullRequest" ALTER COLUMN "author" DROP NOT NULL;
diff --git a/servers/fdr/prisma/schema.prisma b/servers/fdr/prisma/schema.prisma
@@ -244,7 +244,7 @@ model PullRequest {
   repositoryName    String
   repository        Repository @relation(fields: [repositoryOwner, repositoryName], references: [owner, name], onDelete: Cascade)
   
-  author            Bytes
+  author            Bytes?
   reviewers         Bytes
   checks       Bytes
 

diff --git a/servers/fdr/src/api/generated/api/resources/git/types/GithubUser.d.ts b/servers/fdr/src/api/generated/api/resources/git/types/GithubUser.d.ts
diff --git a/servers/fdr/src/api/generated/api/resources/git/types/PullRequest.d.ts b/servers/fdr/src/api/generated/api/resources/git/types/PullRequest.d.ts
diff --git a/servers/fdr/src/db/git/GitDao.ts b/servers/fdr/src/db/git/GitDao.ts
@@ -321,7 +321,7 @@ function convertPrismaPullRequest(maybePR: prisma.PullRequest | null): PullReque
         pullRequestNumber: maybePR.pullRequestNumber,
         repositoryName: maybePR.repositoryName,
         repositoryOwner: maybePR.repositoryOwner,
-        author: readBuffer(maybePR.author) as GithubUser,
+        author: maybePR.author != null ? (readBuffer(maybePR.author) as GithubUser) : undefined,
         reviewers: readBuffer(maybePR.reviewers) as PullRequestReviewer[],
         checks: readBuffer(maybePR.checks) as CheckRun[],
         title: maybePR.title,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		-- AlterTable
		ALTER TABLE "PullRequest" ALTER COLUMN "author" DROP NOT NULL;