Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window icon for linux #1983

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

laur89
Copy link
Contributor

@laur89 laur89 commented Nov 28, 2024

fixes #1978

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

This change adds icon property to main BrowserWindow config, given the build is for linux.

Motivation and Context

This change adds window icon for some window manager under linux that were broken until now, e.g. i3wm.
For context see #1978 or brief conversation on discord

Screenshots

See the related issue #1978

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Note the two items are not checked as I built it via Dockerfile

Release Notes

Fix window icon for some Linux window managers (e.g. i3wm)

src/index.ts Outdated Show resolved Hide resolved
@laur89 laur89 force-pushed the linux-window-icon branch 2 times, most recently from 01a9344 to eb96884 Compare November 29, 2024 08:21
Copy link
Member

@Alphrag Alphrag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on cross-platforms (Windows, MacOS and Linux Debian) and it works as expected. Thanks @laur89!

@Alphrag Alphrag merged commit 7ef2aeb into ferdium:develop Dec 2, 2024
5 checks passed
@laur89 laur89 deleted the linux-window-icon branch December 2, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux] no titlebar icon
2 participants