Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1978
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
This change adds
icon
property to main BrowserWindow config, given the build is for linux.Motivation and Context
This change adds window icon for some window manager under linux that were broken until now, e.g. i3wm.
For context see #1978 or brief conversation on discord
Screenshots
See the related issue #1978
Checklist
pnpm prepare-code
)pnpm test
passesNote the two items are not checked as I built it via Dockerfile
Release Notes
Fix window icon for some Linux window managers (e.g. i3wm)