Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pnpm, electron and other deps #1562

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Feb 10, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

  1. Upgraded pnpm to 8.15.1
  2. Upgraded electron to 28.2.2 (latest stable)
  3. Upgraded other deps (minor and tiny versions) where they are drop-in replacements without any other code change
  4. Use latest commit of the recipes repo (which brings in same target pnpm version)
  5. Add NSFocusStatusUsageDescription which seems to be a new mandatory requirement in upcoming Macos Ventura (I'm running beta of next version - which could be making this mandatory in the future)

Note: Though the fix for persisting the zoom-level has been backported to the 28.x branch of electron, it still isn't present in this version of electron (28.2.2): electron/electron@v28.2.2...28-x-y

Motivation and Context

  1. General upkeep
  2. Use the latest stable electron if the 29 beta doesn't fructify to a working state upon its release.

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam self-assigned this Feb 10, 2024
@vraravam vraravam requested a review from a team as a code owner February 10, 2024 03:55
Copy link
Member

@mcmxcdev mcmxcdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@vraravam vraravam merged commit 83a1325 into ferdium:develop Feb 10, 2024
4 checks passed
@vraravam vraravam deleted the pnpm-upgrade branch February 10, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants