refactor: uninstall node-fetch which is built-in since node 18 #1431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
node-fetch
frompackage.json
fetch
import fromtranslation-helpers.ts
fetch
import fromRecipeController
andUserController
Motivation and Context
https://developer.mozilla.org/en-US/docs/Web/API/fetch#browser_compatibility is available since node 18, so we don't need the dependency anymore.
I verified by playing around with the translation functionality that the native fetch API works properly.
Screenshots
Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes