implement PR feedback

ferdium · Oct 21, 2023 · b4d3dd6 · b4d3dd6
1 parent dd3e049
commit b4d3dd6
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 16 deletions.
diff --git a/src/components/settings/account/AccountDashboard.tsx b/src/components/settings/account/AccountDashboard.tsx
@@ -123,7 +123,7 @@ class AccountDashboard extends Component<IProp> {
           )}
           {!isUsingWithoutAccount && (
             <>
-              {isLoading && <Loader />}
+              {isLoading && <Loader color="#FFFFFF" />}
 
               {!isLoading && userInfoRequestFailed && (
                 <Infobox

diff --git a/src/components/settings/recipes/RecipesDashboard.tsx b/src/components/settings/recipes/RecipesDashboard.tsx
@@ -221,7 +221,7 @@ class RecipesDashboard extends Component<IProps, IState> {
           </div>
 
           {isLoading ? (
-            <Loader color="primary" />
+            <Loader />
           ) : (
             <>
               {recipeFilter === 'dev' && (

diff --git a/src/components/settings/services/ServicesDashboard.tsx b/src/components/settings/services/ServicesDashboard.tsx
@@ -155,7 +155,7 @@ class ServicesDashboard extends Component<IProps> {
             </div>
           )}
           {isLoading ? (
-            <Loader color="primary" />
+            <Loader />
           ) : (
             <table className="service-table" role="grid">
               <tbody>

diff --git a/src/components/settings/team/TeamDashboard.tsx b/src/components/settings/team/TeamDashboard.tsx
@@ -128,7 +128,7 @@ class TeamDashboard extends Component<IProps> {
           </span>
         </div>
         <div className="settings__body">
-          {isLoading && <Loader />}
+          {isLoading && <Loader color="#FFFFFF" />}
 
           {!isLoading && userInfoRequestFailed && (
             <Infobox

diff --git a/src/components/ui/FullscreenLoader/index.tsx b/src/components/ui/FullscreenLoader/index.tsx
@@ -21,7 +21,7 @@ class FullscreenLoader extends Component<IProps> {
   render(): ReactElement {
     const {
       classes,
-      theme = '',
+      theme,
       className = '',
       spinnerColor = '',
       children = null,
@@ -39,9 +39,7 @@ class FullscreenLoader extends Component<IProps> {
         >
           <H1 className={classes.title}>{title}</H1>
           <Loader
-            color={
-              spinnerColor || (theme && theme.colorFullscreenLoaderSpinner)
-            }
+            color={spinnerColor || theme?.colorFullscreenLoaderSpinner}
             loaded={loaded}
           />
           {children && <div className={classes.content}>{children}</div>}

diff --git a/src/components/ui/InfoBar.tsx b/src/components/ui/InfoBar.tsx
@@ -71,7 +71,7 @@ class InfoBar extends Component<IProps> {
                 className="contentWrapper"
                 style={{ display: 'flex', gap: '8px' }}
               >
-                <Loader size={18} loaded={!ctaLoading} />
+                <Loader size={18} loaded={!ctaLoading} color="#FFFFFF" />
                 {ctaLabel}
               </div>
             </button>

diff --git a/src/components/ui/Infobox.tsx b/src/components/ui/Infobox.tsx
@@ -84,7 +84,7 @@ class Infobox extends Component<IProps, IState> {
               className="contentWrapper"
               style={{ display: 'flex', gap: '8px' }}
             >
-              <Loader size={18} loaded={!ctaLoading} />
+              <Loader size={18} loaded={!ctaLoading} color="#FFFFFF" />
               {ctaLabel}
             </div>
           </button>

diff --git a/src/components/ui/button/index.tsx b/src/components/ui/button/index.tsx
@@ -194,7 +194,7 @@ class ButtonComponent extends Component<IProps, IState> {
       <>
         {showLoader && (
           <div className={classes.loaderContainer}>
-            <Loader size={18} />
+            <Loader size={18} color="#FFFFFF" />
           </div>
         )}
         <div className={classes.label}>

diff --git a/src/components/ui/loader/index.tsx b/src/components/ui/loader/index.tsx
@@ -30,11 +30,11 @@ class LoaderComponent extends Component<IProps> {
       classes,
       className,
       size = 36,
-      color = '#FFF',
+      color = this.props.stores?.settings.app.accentColor,
       loaded = false,
     } = this.props;
-    const loaderColor =
-      color === 'primary' ? this.props.stores?.settings.app.accentColor : color;
+    const loaderColor = color || '#FFFFFF';
+
     return (
       <div
         className={classnames({

diff --git a/src/features/workspaces/components/WorkspaceSwitchingIndicator.tsx b/src/features/workspaces/components/WorkspaceSwitchingIndicator.tsx
@@ -45,7 +45,7 @@ const styles = theme => ({
   message: {
     fontSize: 16,
     whiteSpace: 'nowrap',
-    color: '#FFFFFF',
+    color: theme.colorAppLoaderSpinner,
   },
 });
 

diff --git a/src/features/workspaces/components/WorkspacesDashboard.tsx b/src/features/workspaces/components/WorkspacesDashboard.tsx
@@ -137,7 +137,7 @@ class WorkspacesDashboard extends Component<IProps> {
             />
           </div>
           {getUserWorkspacesRequest.isExecuting ? (
-            <Loader color="primary" />
+            <Loader />
           ) : (
             <>
               {/* ===== Workspace could not be loaded error ===== */}