[fix] : fix missing free for compile.Scope (matrixorigin#17932)

fengttt · Aug 7, 2024 · 36ef943 · 36ef943
1 parent 9293eee
commit 36ef943
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/pkg/sql/compile/compile.go b/pkg/sql/compile/compile.go
@@ -3576,6 +3576,7 @@ func (c *Compile) newMergeRemoteScopeByCN(ss []*Scope) []*Scope {
 }
 
 func (c *Compile) newBroadcastJoinScopeList(probeScopes []*Scope, buildScopes []*Scope, n *plan.Node) []*Scope {
+	usedBuildScope := false
 	rs := c.newMergeRemoteScopeByCN(probeScopes)
 	for i := range rs {
 		rs[i].IsJoin = true
@@ -3591,11 +3592,13 @@ func (c *Compile) newBroadcastJoinScopeList(probeScopes []*Scope, buildScopes []
 	// so we set it to false now
 	if c.IsTpQuery() {
 		rs[0].PreScopes = append(rs[0].PreScopes, buildScopes[0])
+		usedBuildScope = true
 	} else {
 		c.anal.isFirst = false
 		for i := range rs {
 			if isSameCN(rs[i].NodeInfo.Addr, c.addr) {
 				mergeBuild := buildScopes[0]
+				usedBuildScope = true
 				if len(buildScopes) > 1 {
 					mergeBuild = c.newMergeScope(buildScopes)
 				}
@@ -3607,6 +3610,12 @@ func (c *Compile) newBroadcastJoinScopeList(probeScopes []*Scope, buildScopes []
 		}
 	}
 
+	if !usedBuildScope {
+		for _, s := range buildScopes {
+			s.release()
+		}
+	}
+
 	return rs
 }