Fixing bugs in flatgeobuf input #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdon
reviewed
Nov 22, 2022
| @@ -168,17 +167,24 @@ void readFeature(const FlatGeobuf::Feature *feature, long long feature_sequence_ | |||
| // https://github.com/protomaps/tippecanoe/issues/7 | |||
| // check if column name is tippecanoe:minzoom, tippecanoe:maxzoom or tippecanoe:layer | |||
|
|
|||
| FlatGeobuf::ColumnType col_type = h_column_types[col_idx]; | |||
| FlatGeobuf::ColumnType col_type; | |||
| if (feature->columns() != NULL) { | |||
There was a problem hiding this comment.
How are you testing this? Last I checked the ogr2ogr writer always puts column type defs in the header.
bdon
reviewed
Nov 22, 2022
| @@ -381,11 +381,7 @@ void parse_flatgeobuf(std::vector<struct serialization_state> *sst, const char * | |||
| long long feature_sequence_id = -1; | |||
| int index_size = 0; | |||
| if (node_size > 0) { | |||
| if (!quiet) { | |||
| fprintf(stderr, "detected indexed FlatGeobuf: assigning feature IDs by sequence\n"); | |||
There was a problem hiding this comment.
Fine with removing this for now; FYI the rationale was that the sequence # in a spatially indexed FGB is the key useful for accessing a single feature in a "cloud-optimized" way to enable potential workflows where Tippecanoe can hold a reference to access whole OGC Features via another fetch. If I find an opportunity to actually implement something like that then maybe it deserves to be in an option sibling to --use-attribute-for-id=... like --use-fgb-seqnum-for-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.