-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to extend zooms if still dropping, but with a limit #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at this with @e-n-f and everything looks good.
As a small thing to tackle in the future, it'd be great if all the triplicated code that happens due to supporting mbtiles, pmtiles and directories, could live on three different sub classes implementing a common interface
Hello! A strange bug, appears at geojson with 38M objects. At smaller ones (about 1M) - did not appear. Compiled from https://github.com/felt/tippecanoe#overzooming At levels 1..14, "Geometry" is added to the "properties" of objects, them become heavy, and with --drop-densest-as-needed application leaves only a few objects per tile.
Here is a part of the original GeoJSON with the same object "2cc5f9f3-a507-4863-9922-466bbb8fba95", there are no "Geometry" inside "properties":
At levels 15..17 - everything is fine. |
There are two changes here:
--extend-zooms-if-still-dropping-maximum
option, which allows the zoom range to be extended if features are still being dropped at maxzoom, but with a limit on the number of zoom levels that may be added--overzoom
option totile-join
, which gives it the long-requested ability to join tilesets with different maxzooms, overzooming tiles from the lower-maxzoom tilesets to extend their zoom range to match the higher-maxzoom tilesets.Fixes mapbox/tippecanoe#693