Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --set-attribute to override existing attribute values #123

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Allow --set-attribute to override existing attribute values #123

merged 2 commits into from
Jul 26, 2023

Conversation

e-n-f
Copy link
Collaborator

@e-n-f e-n-f commented Jul 26, 2023

No description provided.

@e-n-f e-n-f marked this pull request as ready for review July 26, 2023 17:12
joeherm
joeherm approved these changes Jul 26, 2023
View reviewed changes
Copy link

@joeherm joeherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense, test in place! 🚢

@e-n-f e-n-f merged commit 55b9aa5 into main Jul 26, 2023
1 check passed
@e-n-f e-n-f deleted the set-attribute-override branch July 26, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeherm joeherm joeherm approved these changes

@migurski migurski Awaiting requested review from migurski migurski is a code owner

@arredond arredond Awaiting requested review from arredond arredond is a code owner

@dnomadb dnomadb Awaiting requested review from dnomadb dnomadb is a code owner

@ChrisLoer ChrisLoer Awaiting requested review from ChrisLoer ChrisLoer is a code owner

@cduruk cduruk Awaiting requested review from cduruk

@ibesora ibesora Awaiting requested review from ibesora

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-n-f @joeherm