Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics api endpoint #619

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alko89
Copy link

@alko89 alko89 commented Aug 14, 2023

Added api endpoint for metrics. Started working on adding UI support for completed/failed graph, but I suck at React so it might take a while 😅

Updates #618

packages/api/src/queueAdapters/base.ts Outdated Show resolved Hide resolved
example.ts Outdated Show resolved Hide resolved
@felixmosh
Copy link
Owner

Hi @alko89 thank you for this PR, it definitely something that I would like to add to Bull-Board.
Since this data is "on demand" it should not be presented all the time in front of the user, therefore, I think that it can be inside the queue actions drop down, which will open a modal with the graphs, WDYT?

@alko89
Copy link
Author

alko89 commented Aug 15, 2023

@felixmosh personally I would love to have metrics visible as soon as I click on a desired queue - 99% of what I use the dashboard for is to check job statuses and metrics. Maybe add it as the first tab in queue page if they are available, else hide the tab?

image

I'm also fine with other options that you find more appropriate :)

@alko89 alko89 requested a review from felixmosh August 15, 2023 14:51
@dj-fiorex
Copy link

Hi guys, what's missing to make this happen? Can I help in any way? this function is useful

@alko89
Copy link
Author

alko89 commented Oct 24, 2023

Think the API part is done. But I haven't got the time to work on the FE part yet unfortunately.

Copy link

stale bot commented Jan 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 23, 2024
@felixmosh felixmosh added enhancement New feature or request and removed wontfix This will not be worked on labels Jan 23, 2024
@nocodehummel
Copy link

2Cs, when adding Metrics as additional Tab it would be good to reduce the spaces for Tabs. On my screen the tabs-menu requires often horizontal scrolling while other content is visible.

@kyleolsondesign
Copy link

Any chance we could ship the API endpoint and work on the FE as a separate branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants