Add test to proof docblock is being used when type hint is array

felixfbecker · Jan 11, 2021 · 22fe5f9 · 22fe5f9
1 parent 06f0b06
commit 22fe5f9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/lib/Dispatcher.php b/lib/Dispatcher.php
@@ -152,7 +152,7 @@ public function dispatch($msg)
                                 }
                             }
                         } else if ($type instanceof Types\Array_) {
-                            $class = (string)$type->getValueType()->getFqsen();
+                            $class = (string) $type->getValueType()->getFqsen();
                             $value = $this->mapper->mapArray($value, [], $class);
                         } else {
                             throw new Error('Type is not matching @param tag', ErrorCode::INVALID_PARAMS);

diff --git a/tests/DispatcherTest.php b/tests/DispatcherTest.php
@@ -63,7 +63,6 @@ public function testCallMethodWithUnionTypeParamTag()
         $this->assertEquals('Hello World', $result);
         $this->assertEquals($this->calls, [new MethodCall('someMethodWithUnionTypeParamTag', [[new Argument('whatever')]])]);
     }
-
     public function testCallMethodWithTypeHintWithNamedArgsOnNestedTarget()
     {
         $result = $this->dispatcher->dispatch((string)new Request(1, 'nestedTarget->someMethodWithTypeHint', ['arg' => new Argument('whatever')]));
@@ -72,5 +71,11 @@ public function testCallMethodWithTypeHintWithNamedArgsOnNestedTarget()
         $this->assertEquals($this->callsOfNestedTarget, [new MethodCall('someMethodWithTypeHint', [new Argument('whatever')])]);
     }
 
+    public function testCallMethodWithArrayTypeHintAndDocblock(): void
+    {
+        $result = $this->dispatcher->dispatch((string)new Request(1, 'someMethodWithArrayTypeHint', ['args' => [new Argument('1'), new Argument('2')]]));
+        $this->assertEquals('Hello World', $result);
+        $this->assertEquals($this->calls, [new MethodCall('someMethodWithArrayTypeHint', [[new Argument('1'), new Argument('2')]])]);
+    }
 
 }
diff --git a/tests/Target.php b/tests/Target.php
@@ -49,4 +49,13 @@ public function someMethodWithDifferentlyTypedArgs(string $arg1 = null, int $arg
         $this->calls[] = new MethodCall('someMethodWithDifferentlyTypedArgs', func_get_args());
         return 'Hello World';
     }
+
+    /**
+     * @param Argument[] $args
+     */
+    public function someMethodWithArrayTypeHint(array $args): string
+    {
+        $this->calls[] = new MethodCall('someMethodWithArrayTypeHint', func_get_args());
+        return 'Hello World';
+    }
 }