-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New implementation for sifting #21
Open
henry2004y
wants to merge
9
commits into
felixcremer:master
Choose a base branch
from
henry2004y:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+118
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably I should rebase instead of merge... Forgive me as a terrible git user |
Pull Request Test Coverage Report for Build 52
💛 - Coveralls |
This new implementation actually does not give identical results as the original version. I need to figure out why. The reason is that I wrote |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for exploring the possibility of shifting towards the code structure of cg.jl in IterativeSolvers.jl. Compared with the current implementation, it shares the same ideas but in my view easier to follow and maintain:
SiftIterable
for storing sifting variables, instead of oneSiftIterable
and oneSiftState
. All the input variables and intermediate variables are kept in the same place, which may make it easier to add other extensions.iterate
method forSiftIterable
, and anothersift_iterator
method for initializingSiftIterable
. I think this is easier to understand than two dispatchediterate
methods.Besides, I changed some parts of the variable names, e.g.
maxes
-->maxs
,yvec
-->y
, but we can always make better names later.Take a look and we can discuss more about this!