Introduce SELinux policy for libvirt drivers #316
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5umm3r15
force-pushed
the
libvirt-selinux
branch
from
420c5cd
to
256681c
Compare
wrabcak
reviewed
Jul 30, 2020
virt.te
Outdated
| virt_driver_template(virtnetworkd) | ||
|
|
||
| type virtnetworkd_var_run_t; | ||
| files_pid_file(virtnetworkd_var_run_t) |
There was a problem hiding this comment.
You can put declaration of *_var_run_t type to the virt_driver_template() same as you did with process domains.
wrabcak
reviewed
Jul 30, 2020
virt.te
Outdated
| #virtxend | ||
| type virtxend_t; | ||
| type virtxend_exec_t; | ||
| init_daemon_domain(virtxend_t, virtxend_exec_t) |
There was a problem hiding this comment.
Why virt_driver_template is not used here? Is it for purpose?
There was a problem hiding this comment.
I skipped policy for virtxend driver for now.
wrabcak
requested changes
Jul 30, 2020
virt.te
Outdated
| allow virtnwfilterd_t self:rawip_socket create_socket_perms; | ||
|
|
||
| allow virtnwfilterd_t virt_var_run_t:dir { create search_dir_perms }; | ||
| manage_dirs_pattern(virtnwfilterd_t, virtnwfilterd_var_run_t, virtnwfilterd_var_run_t) |
There was a problem hiding this comment.
These set of rules could be part of virt_driver_template
5umm3r15
force-pushed
the
libvirt-selinux
branch
from
256681c
to
ea191fb
Compare
5umm3r15
force-pushed
the
libvirt-selinux
branch
2 times, most recently
from
2cce9c3
to
c1a4d43
Compare
5umm3r15
force-pushed
the
libvirt-selinux
branch
2 times, most recently
from
1bf7799
to
0fa96eb
Compare
5umm3r15
force-pushed
the
libvirt-selinux
branch
from
0fa96eb
to
efecdd0
Compare
5umm3r15
force-pushed
the
libvirt-selinux
branch
3 times, most recently
from
df9ce09
to
63b2ad8
Compare
5umm3r15
force-pushed
the
libvirt-selinux
branch
2 times, most recently
from
1b9d89f
to
54730f7
Compare
New SELinux policy for libvirt drivers: Hypervisor drivers: - virtqemud (QEMU/KVM) - virtlxcd (LXC) - virtvboxd (VirtualBox) Secondary drivers: - virtstoraged (host storage mgmt) - virtnetworkd (virtual network mgmt) - virtinterface (network interface mgmt) - virtnodedevd (physical device mgmt) - virtsecretd (security credential mgmt) - virtnwfilterd (ip[6]tables/ebtables mgmt) - virtproxyd (proxy daemon) SELinux policy for virtvxz and virtxend has not been created yet.
Separate the services from the original virt files that are not libvirt related and create virt_supplementary policy module.
5umm3r15
force-pushed
the
libvirt-selinux
branch
from
54730f7
to
00972fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SELinux policy for libvirt drivers:
Hypervisor drivers:
Secondary drivers:
SELinux policy for virtvxz and virtxend has not been created yet.