chore: merge fedora and upstream spec file #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullr0ute
force-pushed
the
rpm-spec-cleanups
branch
from
3184bf0
to
0d516fc
Compare
|
@coiby can you review these changes, it will align Fedora and here, I think overall it simplifies it somewhat. |
|
While looking at the changes, I notice |
It builds for EPEL-8 but TBH I don't think it makes sense to support py2 so I agree, I had left it because the previous upstream spec had it. Will remove. |
The upstream splits out things that don't really need to be, but have things the Fedora spec doesn't. Merge the two for the best of both worlds so we can use things like packit to automate as much as possible. We also drop the Python2 builds as it's long EOL. Signed-off-by: Peter Robinson <[email protected]>
nullr0ute
force-pushed
the
rpm-spec-cleanups
branch
from
0d516fc
to
24a5d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream splits out things that don't really need to be, but have things the Fedora spec doesn't. Merge the two for the best of both worlds so we can use things like packit to automate as much as possible.