Fix the registration tests

Signed-off-by: Aurélien Bompard <[email protected]>

tests/unit/controller/test_registration.py

@@ -66,6 +66,7 @@ def dummy_stageuser(ipa_testing_config):
         o_mail="[email protected]",
         o_loginshell='/bin/bash',
         fascreationtime=f"{now.isoformat()}Z",
+        fasstatusnote="spamcheck_awaiting",
     )['result']
     yield User(user)
     try:
@@ -126,7 +127,7 @@ def test_gecos(client, post_data_non_ascii, cleanup_dummy_user, mocker):
     # Check that default values are added
     user = User(ipa_admin.stageuser_show("dummy")['result'])
 
-    assert user.gecos == "Xi Jin Ping aeoeue ss AeOeUe Ss An Bei Jin San"
+    assert user.gecos == "Xi Jin Ping aeoeue ss AeOeUe SS An Bei Jin San"
 
 
 @pytest.mark.vcr()
@@ -269,13 +270,15 @@ def test_step_1_spamcheck(
 
 
 @pytest.mark.parametrize(
-    "spamcheck_status", ["spamcheck_awaiting", "spamcheck_denied", "spamcheck_manual"]
+    "spamcheck_status", ["active", "spamcheck_denied", "spamcheck_manual"]
 )
 @pytest.mark.vcr()
 def test_spamcheck_wait(client, dummy_stageuser, spamcheck_status):
     """Test the spamcheck_wait endpoint"""
     ipa_admin.stageuser_mod(a_uid="dummy", fasstatusnote=spamcheck_status)
-    result = client.get('/register/spamcheck-wait?username=dummy')
+    result = client.get(
+        '/register/spamcheck-wait?username=dummy', follow_redirects=True
+    )
     assert result.status_code == 200
 
 
@@ -848,7 +851,6 @@ def logged_in_stage_users_admin(client, make_user, app):
         sess.clear()
 
 
-@pytest.mark.skip("couldnt get this to work")
 @pytest.mark.vcr()
 def test_registering(client, logged_in_stage_users_admin, dummy_stageuser):
     response = client.get("/registering/?status=spamcheck_awaiting")
@@ -922,7 +924,6 @@ def test_registering_delete(client, logged_in_stage_users_admin, dummy_stageuser
     assert len(outbox) == 0
 
 
-@pytest.mark.skip("couldnt get this to work")
 @pytest.mark.vcr()
 def test_registering_invalid_action(
     client, logged_in_stage_users_admin, dummy_stageuser
@@ -948,7 +949,6 @@ def test_registering_unknown_user(client, logged_in_stage_users_admin):
     )
 
 
-@pytest.mark.skip("couldnt get this to work")
 @pytest.mark.parametrize(
     "action,message",
     [
@@ -975,7 +975,6 @@ def test_registering_change_status_error(
     assert len(outbox) == 0
 
 
-@pytest.mark.skip("couldnt get this to work")
 @pytest.mark.vcr()
 def test_registering_delete_error(
     client,