Skip to content

Commit

Permalink
add discussion URL to group page
Browse files Browse the repository at this point in the history
Resolves: #867
Related: fedora-infra/freeipa-fas#144

Signed-off-by: Ryan Lerch <[email protected]>
  • Loading branch information
ryanlerch authored and mergify[bot] committed Feb 27, 2024
1 parent 7c5dd6b commit 36bbc09
Show file tree
Hide file tree
Showing 6 changed files with 364 additions and 352 deletions.
1 change: 1 addition & 0 deletions news/867.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Show the Discussion URL in the group infomation page
1 change: 1 addition & 0 deletions noggin/representation/group.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ class Group(Representation):
"urls": "fasurl",
"irc_channel": "fasircchannel",
"mailing_list": "fasmailinglist",
"discussion_url": "fasdiscussionurl",
}
attr_types = {
"members": "list",
Expand Down
3 changes: 3 additions & 0 deletions noggin/templates/group.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ <h3 class="mb-0">
{% if group.mailing_list %}
<div id="group-mailinglist"><i class="fa fa-fw fa-envelope" aria-hidden="true"></i> <a href="mailto:{{group.mailing_list}}">{{group.mailing_list}}</a></div>
{% endif %}
{% if group.discussion_url %}
<div id="group-discussion_url"><i class="fa fa-fw fa-comment-o" aria-hidden="true"></i> <a href="{{group.discussion_url}}">{{group.discussion_url}}</a></div>
{% endif %}
{% if group.irc_channel %}
<div id="group-ircchannel"><i class="fa fa-fw fa-comments-o" aria-hidden="true"></i> {{ group.irc_channel | channel }}</div>
{% endif %}
Expand Down
1 change: 1 addition & 0 deletions tests/unit/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ def _make_group(name):
fasurl=f"http://{name}.unit.tests",
fasmailinglist=f"{name}@lists.unit.tests",
fasircchannel=f"irc://irc.unit.tests/#{name}",
fasdiscussionurl=f"http://discussion.{name}.unit.tests",
)
created.append(name)
return result
Expand Down
Loading

0 comments on commit 36bbc09

Please sign in to comment.