Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds fedocal support #33

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

rowright8
Copy link

Adds !nextmeeting and !nextmeetings
I am not entirely sure that the test classes are working 100% for the messages for multi line. Any suggestions appreciated.

@ryanlerch
Copy link
Collaborator

Thanks so much for the PR!

Just thinking, I have been trying to use the subcommands to logically group our commands. Not 100% sold on this, but maybe something like:

!calendar nextmeetings

and then just do the alias thing similar to what we do here:

async def alias_oncall(self, evt: MessageEvent, match) -> None:
msg, cmd, arguments = match
if cmd != "oncall":
return
if arguments:
await evt.respond(
"`!oncall` is an alias to `!infra oncall list` please use "
"the `!infra oncall` command for changing the oncall list"
)
return
await self._get_oncall(evt)

itll be a lot simpler, just a straight alias to !nextmeetings and !nextmeeting (the idea behind this is to have the aliases more hidden for compatibility purposes i.e. not in the !help )

Also, i think we can reduce this down to a single command too (!nextmeeting and !nextmeetings) doing the same thing, being:

1.Show (if any) meetings scheduled for the room the command was called in
2. Show the scheduled meetings for all upcoming rooms.

The idea here being having two seperate commands is a bit of overkill, and just outputting all the info is not that bad, because there is really not that much.

@ryanlerch
Copy link
Collaborator

#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants