Copy over some gag commands from old zodbot #22
Conversation
There was a problem hiding this comment.
IMHO, i'm happy leaving these joke commands in old zodbot.
However, if we continue with them here, Just wondering if this would be worth using a passive handler in kind of the same way as we do for the pagureio aliases. I suggest this for two reasons:
- we could then perhaps put these joke commands in configuration, since they are basically the same thing, responding with an emoji and a message.
- they stay out of the main !help -- which i have been working to try to group things under subcommands a lot more to stop it just being a giant list.
Also, with the emoji reactions -- currently it emoji-responds to the ! command message, then replies with an additional message from zodbot. is that what you were intending on happening?
|
Thanks for the feedback.
Fair enough. If the consensus is to get rid of them (/cc @nirik, @abompard in case you have thoughts), I won't be hurt by it.
I could look into that.
I edited the help code to exclude commands from the help if they don't have help text and then didn't add help text here, so they don't show up in
Yes, that was the intention. |
|
I think keeping them would be kinda nice and preserve a bit of history, but if everyone else wants them gone... ok. I suppose if we wanted to be elaborate we could add a way for these to just be configuration/configurable, ie, !addgag name reationemoji reply subject so !addgag fires 🔥 adamw fires {{ subject }} and then !fires nirik But thats getting pretty elaborate. ;) |
| async def fire(self, evt: MessageEvent, firee: str) -> None: | ||
| await evt.mark_read() | ||
| await evt.react("🔥") | ||
| await evt.reply(f"adamw fires {firee}") |
There was a problem hiding this comment.
What does Adam think about being pinged each time someone uses this command?
There was a problem hiding this comment.
Well, it's @AdamWill's thing, we can ask. Though, he was pinged before when it was used.
There was a problem hiding this comment.
i think i'd rather not be pinged. thanks!
No description provided.