Skip to content

Commit

Permalink
chore: move /metrics endpoint to a dedicated port
Browse files Browse the repository at this point in the history
The `/metrics` endpoint was previously exposed on the same port as the public API, which could potentially expose internal monitoring data to external users.
Since this endpoint is intended for internal use and Prometheus monitoring, it should not be publicly accessible.

This commit introduces a separate server listener for Prometheus metrics,
binding it to a dedicated port (default: 127.0.0.1:3001), ensuring that it remains private
  • Loading branch information
hensg committed Sep 23, 2024
1 parent b216553 commit 5db86ad
Show file tree
Hide file tree
Showing 3 changed files with 171 additions and 148 deletions.
199 changes: 78 additions & 121 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion fedimint-clientd/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,8 @@ futures-util = "0.3.30"
clap = { version = "3", features = ["derive", "env"] }
multimint = { version = "0.3.8" }
# multimint = { path = "../multimint" }
axum-otel-metrics = "0.8.0"
hex = "0.4.3"

futures = "0.3"
metrics = { version = "0.23", default-features = false }
metrics-exporter-prometheus = { version = "0.15.3", default-features = false }
Loading

0 comments on commit 5db86ad

Please sign in to comment.