Skip to content

Commit

Permalink
Merge pull request safe-global#329 from safe-global/update-cla-action
Browse files Browse the repository at this point in the history
chore: update CLA action and remove Gnosis references
  • Loading branch information
germartinez authored Jan 24, 2023
2 parents 40061de + 1c68730 commit 2615f6e
Show file tree
Hide file tree
Showing 10 changed files with 27 additions and 18 deletions.
32 changes: 23 additions & 9 deletions .github/workflows/cla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,36 @@ on:
types: [created]
pull_request_target:
types: [opened, closed, synchronize]

jobs:
CLAssistant:
runs-on: ubuntu-latest
steps:
- name: 'CLA Assistant'
if: (github.event.comment.body == 'recheckcla' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target'
# Alpha Release
uses: gnosis/github-action@master
# GitHub token, automatically provided to the action
# (No need to define this secret in the repo settings)
# Beta Release
uses: contributor-assistant/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# the below token should have repo scope and must be manually added by you in the repository's secret
PERSONAL_ACCESS_TOKEN: ${{ secrets.CLA_ACCESS_TOKEN }}
with:
path-to-signatures: 'signatures/version1/cla.json'
path-to-cla-document: 'https://gnosis-safe.io/cla/'
branch: 'cla-signatures'
allowlist: germartinez,mikheevm,rmeissner,Uxio0,dasanra,luarx,lukasschor,tschubotz,bot*,katspaugh
empty-commit-flag: false
blockchain-storage-flag: false
path-to-document: 'https://safe.global/cla/' # e.g. a CLA or a DCO document
# branch should not be protected
branch: 'main'
# user names of users allowed to contribute without CLA
allowlist: germartinez,rmeissner,Uxio0,dasanra,luarx,DaniSomoza,yagopv,JagoFigueroa,bot*

# the followings are the optional inputs - If the optional inputs are not given, then default values will be taken
# enter the remote organization name where the signatures should be stored (Default is storing the signatures in the same repository)
remote-organization-name: 'safe-global'
# enter the remote repository name where the signatures should be stored (Default is storing the signatures in the same repository)
remote-repository-name: 'cla-signatures'
#create-file-commit-message: 'For example: Creating file for storing CLA Signatures'
#signed-commit-message: 'For example: $contributorName has signed the CLA in #$pullRequestNo'
#custom-notsigned-prcomment: 'pull request comment with Introductory message to ask new contributors to sign'
#custom-pr-sign-comment: 'The signature to be committed in order to sign the CLA'
#custom-allsigned-prcomment: 'pull request comment when all contributors has signed, defaults to **CLA Assistant Lite bot** All Contributors have signed the CLA.'
#lock-pullrequest-aftermerge: false - if you don't want this bot to automatically lock the pull request after merging (default - true)
#use-dco-flag: true - If you are using DCO instead of CLA
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Safe Core SDK Monorepo

[![Logo](https://raw.githubusercontent.com/gnosis/safe-core-sdk/main/assets/logo.png)](https://gnosis-safe.io/)
[![Logo](https://raw.githubusercontent.com/safe-global/safe-core-sdk/main/assets/logo.png)](https://safe.global/)

![license](https://img.shields.io/github/license/safe-global/safe-core-sdk)

Software developer tools that facilitate the interaction with the Safe [contracts](https://github.com/safe-global/safe-contracts) and [services](https://github.com/safe-global/safe-transaction-service).

Expand Down
1 change: 0 additions & 1 deletion packages/safe-core-sdk-types/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"SDK"
],
Expand Down
1 change: 0 additions & 1 deletion packages/safe-core-sdk-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"SDK"
],
Expand Down
2 changes: 1 addition & 1 deletion packages/safe-core-sdk/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ npm build

## <a name="getting-started">Getting Started</a>

The following steps show how to set up the Safe Core SDK, deploy a new Safe, create a Safe transaction, generate the required signatures from owners and execute the transaction. However, using the Safe Core SDK alone will not allow for the collection of owner signatures off-chain. To do this and be able to see and confirm the pending transactions shown in the [Safe Web App](https://gnosis-safe.io/app/), it is recommended that you follow this other [guide](/guides/integrating-the-safe-core-sdk.md) that covers the use of the Safe Core SDK, combined with the Safe Service Client.
The following steps show how to set up the Safe Core SDK, deploy a new Safe, create a Safe transaction, generate the required signatures from owners and execute the transaction. However, using the Safe Core SDK alone will not allow for the collection of owner signatures off-chain. To do this and be able to see and confirm the pending transactions shown in the [Safe Web App](https://app.safe.global/), it is recommended that you follow this other [guide](/guides/integrating-the-safe-core-sdk.md) that covers the use of the Safe Core SDK, combined with the Safe Service Client.

### 1. Instantiate an EthAdapter

Expand Down
1 change: 0 additions & 1 deletion packages/safe-core-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"SDK"
],
Expand Down
1 change: 0 additions & 1 deletion packages/safe-ethers-adapters/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"Ethers"
],
Expand Down
1 change: 0 additions & 1 deletion packages/safe-ethers-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"SDK",
"Ethers"
Expand Down
1 change: 0 additions & 1 deletion packages/safe-service-client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"Service"
],
Expand Down
1 change: 0 additions & 1 deletion packages/safe-web3-lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"typings": "dist/src/index.d.ts",
"keywords": [
"Ethereum",
"Gnosis",
"Safe",
"SDK",
"Web3"
Expand Down

0 comments on commit 2615f6e

Please sign in to comment.