fix CI test runs #283
Merged
fix CI test runs #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in CI, the tests are run using docker-compose targeting ./concourse/tasks/integration.yml. for instance, to repro locally, i ran `docker-compose -f concourse/tasks/integration.yml run tests-310`. however, the faunadb container is brought up by the test's docker-compose stack because the tests depends_on the database container. but since the tests don't require the container to be healthy (merely existent), they fail well before the database container is up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in CI, the tests are run using docker-compose targeting ./concourse/tasks/integration.yml. for instance, to repro locally, i ran
docker-compose -f concourse/tasks/integration.yml run tests-310.however, the faunadb container is brought up by the test's docker-compose stack because the tests depends_on the database container. but since the tests don't require the container to be healthy (merely existent), they fail well before the database container is up.
failing local run on v4 branch (repros failure in CI):
passing local run on this branch (demonstrates fix should work in CI):
