download language server #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauna-chase
force-pushed
the
download-lserver
branch
from
a65fa9d
to
e6a964a
Compare
ENG-5263 The plugin will now download the language server if it isn't already present. The ability to refresh the server will be done in a separate pr.
macmv
reviewed
Jul 20, 2023
There was a problem hiding this comment.
looks good, I'm curious about axios though. Can we avoid adding that dependency if all we need to do is a get request? I think node has a builtin http module that is similarly easy to use.
If axios is a lot easier we can stick with it, I'd just like to avoid adding large dependencies when we don't need them.
fauna-chase
force-pushed
the
download-lserver
branch
2 times, most recently
from
6fb1c7a
to
cb830fc
Compare
This will allow us to run the github action tests against dev fauna. Unfortunately github actions services are only supported for linux runners so if we want to run our extension tests on the other oses we'll need to use dev from them.
fauna-chase
force-pushed
the
download-lserver
branch
2 times, most recently
from
c423614
to
754b1a7
Compare
fauna-chase
force-pushed
the
download-lserver
branch
3 times, most recently
from
09d698b
to
9132053
Compare
fauna-chase
force-pushed
the
download-lserver
branch
from
9132053
to
2110ec3
Compare
macmv
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENG-5263 ENG-5309 ENG-5283
The plugin will now download the language server if it isn't already present. The ability to refresh the server will be done in a separate pr.