Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename config to fauna #32

Merged
merged 1 commit into from
Sep 12, 2023
Merged

rename config to fauna #32

merged 1 commit into from
Sep 12, 2023

Conversation

fauna-chase
Copy link
Contributor

Feels a bit weird to have the config titles include vscode. Also figured out a better way to link directly to the extension configuration so it won't overlap with the previous extension config

Feels a bit weird to have the config titles include vscode.  Also
figured out a better way to link directly to the extension configuration
so it won't overlap with the previous extension config
@@ -150,7 +150,7 @@
"viewsWelcome": [
{
"view": "welcomeView",
"contents": "Welcome to the Fauna VSCode extension! To get started, configure your environment:\n[Configure Fauna Extension](command:workbench.action.openSettings?%22fauna-vscode%22)\nOnce configured, open the FQL Playground to begin writing queries!\n[Open FQL Playground](command:fauna-vscode.togglePlayground)\n"
"contents": "Welcome to the Fauna VSCode extension! To get started, configure your environment:\n[Configure Fauna Extension](command:workbench.action.openSettings?%22@ext:fauna.fauna-vscode%22)\nOnce configured, open the FQL Playground to begin writing queries!\n[Open FQL Playground](command:fauna-vscode.togglePlayground)\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo very nice

Copy link
Collaborator

@macmv macmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this fixes the vscode title, lgtm

@fauna-chase fauna-chase merged commit 1ffa5b2 into main Sep 12, 2023
3 checks passed
@fauna-chase fauna-chase deleted the rename-config branch September 12, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants