Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-3263] Add GTM tags to JS driver API index #283

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Aug 16, 2024

Ticket(s): DOCS-3263

Problem

When we publish API ref docs for the JS driver, we don't include GTM tags in the index. The tags let us track traffic to the docs.

Also fixes some copy/paste errors in the docs script from #282

Solution

Update the docs build script to include the tags. Implementation is based on what we use in other drivers. Ex: https://github.com/fauna/fauna-python/blob/main/concourse/scripts/publish_docs.sh

Testing

I don't have access to Concourse so I can't test this myself. However, the publish docs task occurs after the package is published so this won't block releases.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jrodewig jrodewig merged commit 572f94f into main Aug 16, 2024
5 checks passed
@jrodewig jrodewig deleted the add-gtm-tags-to-api-ref branch August 16, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants