Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring and readme with changes requested in #277 #280

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

ecooper
Copy link
Contributor

@ecooper ecooper commented Jul 29, 2024

Ticket(s): FE-5389

Problem

#277 introduced a typo in a client docstring and new type testing techniques that are not explicitly called out in the README.

Solution

  • Fix spacing typo
  • Add a new "Asserting type behavior" in the "Contributing" section of the readme

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ecooper ecooper merged commit 9f115a3 into main Jul 30, 2024
5 checks passed
@ecooper ecooper deleted the readme-and-docstring-fixes branch July 30, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants