Revert error handling for standard queries #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-5419
Problem
Driver tests are intermittently failing for GOAWAY issues. This should have been covered by retries, but changes to wrap errors in NetworkError classes are preventing those retries from working.
See also v1.3.1...v2.0.0
Also, this code is not touched by event streaming, so the error message is incorrect.
Solution
Revert the changes to error handling for standard queries.
Result
Should fix error handling for GOAWAYs, and have no impact on any other error handling or responses to the end users.
Out of scope
dedicated tests to cover HTTP/2 GOAWAY issues
Testing
we should see improvement in downstream tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.