Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-2743] Replace FQLX beta docs links in main branch #261

Merged
merged 5 commits into from
May 8, 2024

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 7, 2024

Ticket(s): DOCS-2743

Problem

Links to docs are still using the old FQL beta urls.

Solution

Update the links!

Out of scope

N/A

Testing

No functional changes.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jrodewig jrodewig force-pushed the replace-fqlx-beta-doc-links branch 5 times, most recently from dfae8e4 to f841b36 Compare May 7, 2024 20:31
@jrodewig jrodewig force-pushed the replace-fqlx-beta-doc-links branch from f841b36 to 11319ea Compare May 7, 2024 20:41
@jrodewig jrodewig requested review from ptpaterson, cleve-fauna and pnwpedro and removed request for ptpaterson May 7, 2024 20:42
@jrodewig jrodewig marked this pull request as ready for review May 7, 2024 20:45
ptpaterson
ptpaterson previously approved these changes May 8, 2024
Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The failed tests are not auth errors. They're just flakely due to timeouts or something. Note that the tests passed for Node v18.

Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests passing! 🚀

@ptpaterson ptpaterson merged commit a54f4a9 into main May 8, 2024
5 checks passed
@ptpaterson ptpaterson deleted the replace-fqlx-beta-doc-links branch May 8, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants