Revert embedding snippets in objects and arrays due to performance issues with such queries #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues with such queries
cleve-fauna
changed the title
henryfauna
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-3501
Problem
Need to release a patch version to mark 1.3.0 deprecated.
We are deprecating 1.3.0 for a bit until performance issues with FQL snippets in objects and arrays is resolved.
Solution
Revert FQL snippet support in objects and arrays and patch version.
Result
Performance risk removed and we can deprecate 1.3.0 without marking entire fauna npm package as deprecated.
Testing
Full suite
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.