BT-4181: Query limits test case and pipeline collateral #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambollen
requested review from
cynicaljoy,
ptpaterson,
pnwpedro and
cleve-fauna
cynicaljoy
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): BT-4181
Problem
We don't currently have integration test coverage of the query-limit and throttling behavior.
Solution
Add a test case that runs against a specially-configured database with query limits and validate that the queries that are throttled succeed on the Client retry logic.
Depends on this PR: https://github.com/fauna/testtools/pull/86
Result
New test case added and running in pipeline.
Out of scope
Testing
Ran the test many times locally; will need to validate in the pipeline that the Concourse collateral is setup correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.