Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add an ellipsoid for the Moon #13

Closed
wants to merge 4 commits into from
Closed

WIP Add an ellipsoid for the Moon #13

wants to merge 4 commits into from

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented Jan 9, 2020

Use values from the compilation in Wieczorek (2015).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

@leouieda leouieda changed the title Add an ellipsoid for the Moon WIP Add an ellipsoid for the Moon Jan 9, 2020
@leouieda
Copy link
Member Author

leouieda commented Jan 9, 2020

Tests fail because the equations fail (nan) when the flattening is 0. That leads to eccentricities being 0 and there are divisions of these values in the equations. The only sensible way forward I can see is to create a separate Sphere class that has simplified equations for a reference sphere. It would actually be a lot simpler since we'd be using spherical coordinates by default and so wouldn't need the coordinate conversions. The gravity equations is also a lot simpler.

@leouieda
Copy link
Member Author

leouieda commented Jul 8, 2020

Maybe a better way forward is to check if the flattening is close to zero and then use the sphere equation instead. That way we don’t need a new class and the associated maintenance.

@santisoler
Copy link
Member

I have updated this PR by defining the MOON ellipsoids as an instance of the new Sphere class introduced on #42.
I faced a bug on how the Sphere class computes the gravity on the equator, which should be fixed on #48.
After that, I think the Moon implementation should be ready, maybe we could add a gallery example for it.

@leouieda
Copy link
Member Author

leouieda commented Oct 8, 2020

Closing this since the approach wouldn't work. See #53 instead.

@leouieda leouieda closed this Oct 8, 2020
@leouieda leouieda deleted the moon branch October 13, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants