Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Allow to pass any requestable undici instance #405

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

types: Allow to pass any requestable undici instance #405

wants to merge 2 commits into from

Conversation

g12i
Copy link

@g12i g12i commented Jan 17, 2025 •
edited
Loading

undici accepts any kind of Dispatcher, however this was not reflected in types

Checklist

mcollina
mcollina requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for types.

@g12i
Copy link
Author

g12i commented Jan 23, 2025

Hello @mcollina, sure added in 9ce5f66

mcollina
mcollina approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dancastillo
dancastillo approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g12i
Copy link
Author

g12i commented Jan 27, 2025

Nice, thank you @mcollina @gurgunday @dancastillo. I don't have rights to merge this so I leave it up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@dancastillo dancastillo dancastillo approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g12i @mcollina @dancastillo @gurgunday