-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic user management #503
Conversation
178ba18
to
1bcba6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great first draft!
I made some nits, but overall I like the direction you're taking this 👍
However I think we might want to define a couple of explicit scenarios that we want to support.
Here's one (complex) scenario I'm thinking about:
- a family consisting of 2 parents, and 2 children and a caregiver (nurse, babysitter, grandparent).
- both parents need to be able to access both children's records, and maybe each-others
- the caregiver should have view-only access to 1 or both children, but not the parents.
Given my understanding of the current admin role, the parents and caregivers would all need Admin access, and would be able to see every ones records.
though, now that I'm thinking about this, you probably plan to add access control as a separate PR, since we mentioned a dedicated lookup table in our conversations on Discord. Since this is just for user management (and alleviating concerns that unknown users are creating accounts on the server), I think this is fine.
Before you begin the access control PR, we should definitely define the scenarios we want to support (and the ones we dont).
a2e224e
to
8eb613b
Compare
8eb613b
to
0ac3f54
Compare
This adds:
role
onUser
(can beadmin
oruser
right now)Part of #57