WIP fixing tests (1 failure)

fastenhealth · Oct 30, 2023 · 8652218 · 8652218
1 parent 627b697
commit 8652218
Show file tree

Hide file tree

Showing 7 changed files with 60 additions and 6 deletions.
diff --git a/frontend/src/app/components/medical-sources-card/medical-sources-card.component.ts b/frontend/src/app/components/medical-sources-card/medical-sources-card.component.ts
@@ -24,6 +24,7 @@ export class MedicalSourcesCardComponent implements OnInit {
   }
 
   getSourceDisplayName(sourceItem: SourceListItem): string {
+    if(!sourceItem) return "Unknown"
     if(sourceItem.metadata?.display) {
       return sourceItem.metadata?.display
     }

diff --git a/frontend/src/app/pages/background-jobs/background-jobs.component.spec.ts b/frontend/src/app/pages/background-jobs/background-jobs.component.spec.ts
@@ -1,14 +1,26 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { BackgroundJobsComponent } from './background-jobs.component';
+import {HttpClientTestingModule} from '@angular/common/http/testing';
+import {RouterTestingModule} from '@angular/router/testing';
+import {FormsModule, ReactiveFormsModule} from '@angular/forms';
+import {HTTP_CLIENT_TOKEN} from '../../dependency-injection';
+import {HttpClient} from '@angular/common/http';
 
 describe('BackgroundJobsComponent', () => {
   let component: BackgroundJobsComponent;
   let fixture: ComponentFixture<BackgroundJobsComponent>;
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      declarations: [ BackgroundJobsComponent ]
+      declarations: [ BackgroundJobsComponent ],
+      imports: [HttpClientTestingModule],
+      providers: [
+        {
+          provide: HTTP_CLIENT_TOKEN,
+          useClass: HttpClient,
+        },
+      ]
     })
     .compileComponents();
 

diff --git a/frontend/src/app/pages/report-labs/report-labs.component.spec.ts b/frontend/src/app/pages/report-labs/report-labs.component.spec.ts
@@ -4,6 +4,7 @@ import { ReportLabsComponent } from './report-labs.component';
 import {FastenApiService} from '../../services/fasten-api.service';
 import {NgbModalModule} from '@ng-bootstrap/ng-bootstrap';
 import {of} from 'rxjs';
+import {RouterTestingModule} from '@angular/router/testing';
 
 describe('ReportLabsComponent', () => {
   let component: ReportLabsComponent;
@@ -12,16 +13,18 @@ describe('ReportLabsComponent', () => {
 
   beforeEach(async () => {
 
-    mockedFastenApiService = jasmine.createSpyObj('FastenApiService', ['getResources'])
+    mockedFastenApiService = jasmine.createSpyObj('FastenApiService', ['getResources', 'queryResources'])
     await TestBed.configureTestingModule({
       declarations: [ ReportLabsComponent ],
+      imports: [RouterTestingModule],
       providers: [{
         provide: FastenApiService,
         useValue: mockedFastenApiService
       }]
     })
     .compileComponents();
     mockedFastenApiService.getResources.and.returnValue(of([]));
+    mockedFastenApiService.queryResources.and.returnValue(of([]));
 
     fixture = TestBed.createComponent(ReportLabsComponent);
     component = fixture.componentInstance;

diff --git a/frontend/src/app/services/event-bus.service.spec.ts b/frontend/src/app/services/event-bus.service.spec.ts
@@ -1,12 +1,23 @@
 import { TestBed } from '@angular/core/testing';
 
 import { EventBusService } from './event-bus.service';
+import {HttpClientTestingModule} from '@angular/common/http/testing';
+import {HTTP_CLIENT_TOKEN} from '../dependency-injection';
+import {HttpClient} from '@angular/common/http';
 
 describe('EventBusService', () => {
   let service: EventBusService;
 
   beforeEach(() => {
-    TestBed.configureTestingModule({});
+    TestBed.configureTestingModule({
+      imports: [HttpClientTestingModule],
+      providers: [
+        {
+          provide: HTTP_CLIENT_TOKEN,
+          useClass: HttpClient,
+        },
+      ]
+    });
     service = TestBed.inject(EventBusService);
   });
 

diff --git a/frontend/src/app/widgets/image-list-group-widget/image-list-group-widget.component.spec.ts b/frontend/src/app/widgets/image-list-group-widget/image-list-group-widget.component.spec.ts
@@ -1,14 +1,24 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { ImageListGroupWidgetComponent } from './image-list-group-widget.component';
+import {FastenApiService} from '../../services/fasten-api.service';
+import {HTTP_CLIENT_TOKEN} from '../../dependency-injection';
+import {HttpClient} from '@angular/common/http';
+import {HttpClientTestingModule} from '@angular/common/http/testing';
 
 describe('ImageListGroupWidgetComponent', () => {
   let component: ImageListGroupWidgetComponent;
   let fixture: ComponentFixture<ImageListGroupWidgetComponent>;
 
   beforeEach(async () => {
     await TestBed.configureTestingModule({
-      declarations: [ ImageListGroupWidgetComponent ]
+      imports: [ ImageListGroupWidgetComponent, HttpClientTestingModule ],
+      providers: [
+        {
+          provide: HTTP_CLIENT_TOKEN,
+          useClass: HttpClient,
+        },
+      ]
     })
     .compileComponents();
 

diff --git a/frontend/src/app/widgets/patient-vitals-widget/patient-vitals-widget.component.spec.ts b/frontend/src/app/widgets/patient-vitals-widget/patient-vitals-widget.component.spec.ts
@@ -16,7 +16,6 @@ describe('PatientVitalsWidgetComponent', () => {
 
   beforeEach(async () => {
     mockedFastenApiService = jasmine.createSpyObj('FastenApiService', ['queryResources'])
-
     await TestBed.configureTestingModule({
       imports: [ PatientVitalsWidgetComponent, RouterTestingModule ],
       providers: [

diff --git a/frontend/src/app/widgets/records-summary-widget/records-summary-widget.component.spec.ts b/frontend/src/app/widgets/records-summary-widget/records-summary-widget.component.spec.ts
@@ -1,16 +1,34 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 
 import { RecordsSummaryWidgetComponent } from './records-summary-widget.component';
+import {FastenApiService} from '../../services/fasten-api.service';
+import {HTTP_CLIENT_TOKEN} from '../../dependency-injection';
+import {HttpClient} from '@angular/common/http';
+import {RouterTestingModule} from '@angular/router/testing';
+import {of} from 'rxjs';
 
 describe('RecordsSummaryWidgetComponent', () => {
   let component: RecordsSummaryWidgetComponent;
   let fixture: ComponentFixture<RecordsSummaryWidgetComponent>;
+  let mockedFastenApiService
 
   beforeEach(async () => {
+    mockedFastenApiService = jasmine.createSpyObj('FastenApiService', ['getSummary'])
     await TestBed.configureTestingModule({
-      declarations: [ RecordsSummaryWidgetComponent ]
+      imports: [ RecordsSummaryWidgetComponent, RouterTestingModule ],
+      providers: [
+        {
+          provide: FastenApiService,
+          useValue: mockedFastenApiService
+        },
+        {
+          provide: HTTP_CLIENT_TOKEN,
+          useClass: HttpClient,
+        }
+      ]
     })
     .compileComponents();
+    mockedFastenApiService.getSummary.and.returnValue(of({}));
 
     fixture = TestBed.createComponent(RecordsSummaryWidgetComponent);
     component = fixture.componentInstance;