Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons to svg #69

Merged
merged 4 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ jobs:
strategy:
matrix:
include:
- redmine-repository: 'redmica/redmica'
redmine-version: 'stable-3.0'
ruby-version: '3.3'
- redmine-repository: 'redmica/redmica'
redmine-version: 'master'
ruby-version: '3.3'
Expand Down
8 changes: 2 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,17 @@
# redmine_message_customize

This is a plugin for Redmine.
This plugin changes the translation of the wording on the screen defined in "config/locales/*.yml" in the admin view.
This plugin changes the translation of the wording on the screen defined in "config/locales/*.yml" in the admin view.
It is available for Redmine 6.0 or later.

## Install

```
$ cd /your/path/redmine
$ git clone https://github.com/farend/redmine_message_customize.git plugins/redmine_message_customize
$ # When Redmine 4.1 or lower versions
$ cp plugins/redmine_message_customize/35_change_load_order_locales.rb config/initializers/35_change_load_order_locales.rb
$ # redmine restart
```

:warning: To customize messages for other plugins in **Redmine 4.1 or lower versions**, redmine_message_customize/35_change_load_order_locales.rb It is necessary to copy the file to redmine/config/initializers.
If redmine/config/initializers/35_change_load_order_locales.rb is missing, only non-plugin messages can be customized.

## Usage

* 1: Open setting page
Expand Down
8 changes: 4 additions & 4 deletions app/helpers/custom_message_settings_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@ def normal_mode_input_fields(setting, lang)
content += content_tag(:p) do
content_tag(:label, k) +
text_field_tag("settings[custom_messages][#{k}]", v.to_s) +
link_to_function('', '$(this).closest("p").remove();', class: 'icon icon-del clear-key-link')
link_to_function(sprite_icon('del'), '$(this).closest("p").remove()', class: 'icon clear-key-link')
end
end
content
end

def open_default_messages_window_link(lang)
link_to l(:label_default_messages),
link_to sprite_icon('file', l(:label_default_messages)),
default_messages_custom_message_settings_path(lang: lang),
class: 'icon icon-file text-plain',
class: 'icon text-plain',
onclick: "window.open(this.href,'redmine_message_customize_plugin-default_messages', 'height=800, width=500');return false;",
id: 'default-messages-link'
end
end
end
8 changes: 4 additions & 4 deletions app/views/custom_message_settings/_messages.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div>
<%= select_tag 'select-key', available_message_options(@setting, lang), id: 'key-selector' %>
<span class='icon icon-help'><%= l(:text_description_of_search_box) %></span>
<span class='icon'><%= sprite_icon('help', l(:text_description_of_search_box)) %></span>
</div>
<br>
<div class='tabular'>
Expand Down Expand Up @@ -43,10 +43,10 @@ function AddMessageInputField(key, val){
name: 'settings[custom_messages][' + key + ']'
}).appendTo($('#edit-custom-messages .tabular p:first'));
$('<a>').attr({
class: 'icon icon-del clear-key-link',
class: 'icon clear-key-link',
href: '#',
onclick: '$(this).closest("p").remove();; return false;'
}).appendTo($('#edit-custom-messages .tabular p:first'));
onclick: '$(this).closest("p").remove(); return false;'
}).html('<%= sprite_icon('del') %>').appendTo($('#edit-custom-messages .tabular p:first'));
$('#key-selector').val('').change();
$('#key-selector option[value="' + key + '"]').prop("disabled", true).change();
setSelect2();
Expand Down
2 changes: 1 addition & 1 deletion app/views/custom_message_settings/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<% end %>

<div class='message-customize-menu contextual'>
<%= link_to (@setting.enabled? ? l(:label_disable_customize) : l(:label_enable_customize)), toggle_enabled_custom_message_settings_path, method: :post, class: 'icon icon-settings' %> /
<%= link_to sprite_icon('settings', (@setting.enabled? ? l(:label_disable_customize) : l(:label_enable_customize))), toggle_enabled_custom_message_settings_path, method: :post, class: 'icon' %> /
<%= open_default_messages_window_link(@lang) %>
</div>

Expand Down
4 changes: 2 additions & 2 deletions init.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
author_url 'https://github.com/farend'
settings default: { custom_messages: {} }
menu :admin_menu, :custom_messages, { controller: 'custom_message_settings', action: 'edit' },
caption: :label_custom_messages, html: { class: 'icon icon-edit' }
requires_redmine version_or_higher: '3.2'
caption: :label_custom_messages, html: { class: 'icon' }, icon: 'edit'
requires_redmine version_or_higher: '6.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

end

Rails.application.config.i18n.load_path += Dir.glob(File.join(p.directory, 'config', 'locales', 'custom_messages', '*.rb'))