Skip to content

Commit

Permalink
Remove unnecessary classes
Browse files Browse the repository at this point in the history
  • Loading branch information
ishikawa999 committed Nov 18, 2024
1 parent 30323d1 commit 7f7fe09
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions app/helpers/custom_message_settings_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def normal_mode_input_fields(setting, lang)
content += content_tag(:p) do
content_tag(:label, k) +
text_field_tag("settings[custom_messages][#{k}]", v.to_s) +
link_to_function(sprite_icon('del'), '$(this).closest("p").remove()', class: 'icon icon-del clear-key-link')
link_to_function(sprite_icon('del'), '$(this).closest("p").remove()', class: 'icon clear-key-link')
end
end
content
Expand All @@ -26,7 +26,7 @@ def normal_mode_input_fields(setting, lang)
def open_default_messages_window_link(lang)
link_to sprite_icon('file', l(:label_default_messages)),
default_messages_custom_message_settings_path(lang: lang),
class: 'icon icon-file text-plain',
class: 'icon text-plain',
onclick: "window.open(this.href,'redmine_message_customize_plugin-default_messages', 'height=800, width=500');return false;",
id: 'default-messages-link'
end
Expand Down
4 changes: 2 additions & 2 deletions app/views/custom_message_settings/_messages.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div>
<%= select_tag 'select-key', available_message_options(@setting, lang), id: 'key-selector' %>
<span class='icon icon-help'><%= sprite_icon('help', l(:text_description_of_search_box)) %></span>
<span class='icon'><%= sprite_icon('help', l(:text_description_of_search_box)) %></span>
</div>
<br>
<div class='tabular'>
Expand Down Expand Up @@ -43,7 +43,7 @@ function AddMessageInputField(key, val){
name: 'settings[custom_messages][' + key + ']'
}).appendTo($('#edit-custom-messages .tabular p:first'));
$('<a>').attr({
class: 'icon icon-del clear-key-link',
class: 'icon clear-key-link',
href: '#',
onclick: '$(this).closest("p").remove(); return false;'
}).html('<%= sprite_icon('del') %>').appendTo($('#edit-custom-messages .tabular p:first'));
Expand Down
2 changes: 1 addition & 1 deletion app/views/custom_message_settings/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<% end %>

<div class='message-customize-menu contextual'>
<%= link_to sprite_icon('settings', (@setting.enabled? ? l(:label_disable_customize) : l(:label_enable_customize))), toggle_enabled_custom_message_settings_path, method: :post, class: 'icon icon-settings' %> /
<%= link_to sprite_icon('settings', (@setting.enabled? ? l(:label_disable_customize) : l(:label_enable_customize))), toggle_enabled_custom_message_settings_path, method: :post, class: 'icon' %> /
<%= open_default_messages_window_link(@lang) %>
</div>

Expand Down
2 changes: 1 addition & 1 deletion init.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
author_url 'https://github.com/farend'
settings default: { custom_messages: {} }
menu :admin_menu, :custom_messages, { controller: 'custom_message_settings', action: 'edit' },
caption: :label_custom_messages, html: { class: 'icon icon-edit' }, icon: 'edit'
caption: :label_custom_messages, html: { class: 'icon' }, icon: 'edit'
requires_redmine version_or_higher: '6.0'
end

Expand Down

0 comments on commit 7f7fe09

Please sign in to comment.