fix: Add require shim to esbuild #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adityapk00
force-pushed
the
esbuildfix
branch
from
b0e638d
to
bed5ddf
Compare
Signed-off-by: Aditya Kulkarni <[email protected]>
adityapk00
force-pushed
the
esbuildfix
branch
from
bed5ddf
to
79b7dd5
Compare
adityapk00
added a commit
to adityapk00/hub
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Aditya Kulkarni <[email protected]>
adityapk00
added a commit
that referenced
this pull request
Jan 25, 2023
* feat: Add RPC implementation * wip * feat: protobufs signer store (#449) * add IdRegistryEvent proto and utils * add signerStore * add signer store to engine * add changeset * wip * feat: protobufs cast store (#452) * protobuf cast store * reuse makeCastIdKey and fix import format * wip * fix: Add require shim to esbuild (#453) * sync engine test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix an issue where esbuild would not work with the dynamic requires coming from grpc-js
Change Summary
requireshim neededMerge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewAdditional Context
More information about the problem here: sveltejs/kit#2400
ES build PR that this is copied from: evanw/esbuild#2067
Adding this as a separate PR so I can revert it easily later if needed.