Merge pull request #1 from faraazahmad/housekeeping

chore: perform housekeeping

Gemfile

@@ -2,12 +2,8 @@
 
 source "https://rubygems.org"
 
-# gem "rails"
-
 gem "syntax_tree", "~> 6.2"
 
 gem "rubocop", "~> 1.57", groups: %i[development test]
-
-gem "rake", "~> 13.0", :groups => [:development, :test]
-
-gem "rspec", "~> 3.12", :groups => [:development, :test]
+gem "rake", "~> 13.0", groups: %i[development test]
+gem "rspec", "~> 3.12", groups: %i[development test]

lib/tainted/lint.rb

@@ -5,7 +5,7 @@ class Lint
     def initialize(filepath, sources, sinks)
       @filepath = filepath
 
-      t = Tainted::DataFlow.new(@filepath)
+      t = DataFlow.new(@filepath)
       t.generate
       var_dependencies = t.tainted
       State.instance.var_dependencies = var_dependencies

lib/tainted/static.rb

@@ -4,10 +4,11 @@ module Tainted
   class Static < SyntaxTree::Visitor
     attr_reader :result
 
-    def initialize(sources, _sinks)
+    def initialize(sources, sinks)
       super()
 
       @sources = sources
+      @sinks = sinks
       @result = []
     end
 
@@ -45,6 +46,8 @@ def parse_call(node)
         arguments.map { |arg| [arg, taint_status(arg.value.value.to_sym)] }
 
       method_name = node.message.value
+      return unless @sinks.include?(method_name.to_sym)
+
       taint_statuses.each do |status|
         next unless status[1]
 

spec/lib/tainted/lint_spec.rb

@@ -0,0 +1,18 @@
+# frozen_stirng_literal: true
+
+RSpec.describe Tainted::Lint do
+  context "Given a file with tainted sources and sinks" do
+    it "returns a result listing the taint errors" do
+      file = File.expand_path "#{__dir__}/../../fixtures/simple.rb"
+      lint = Tainted::Lint.new(file, %i[tainted], %i[unsafe])
+      result = lint.analyze
+
+      expect(result).to eq(
+        [
+          "Method `unsafe()` consuming tainted variable `d`",
+          "Method `unsafe()` consuming tainted variable `c`"
+        ]
+      )
+    end
+  end
+end

spec/tainted_spec.rb

@@ -4,16 +4,4 @@
   it "has a version number" do
     expect(Tainted::VERSION).not_to be nil
   end
-
-  it "does something useful" do
-    file = "#{__dir__}/../fixtures/simple.rb"
-    lint = Tainted::Lint.new(file, %i[tainted], %i[unsafe])
-    result = lint.analyze
-    expect(result).to eq(
-      [
-        "Method `unsafe()` consuming tainted variable `d`",
-        "Method `unsafe()` consuming tainted variable `c`"
-      ]
-    )
-  end
 end