Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): create-comment workflows array length check. #2125

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 21, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Fix after #2123.
This time properly tested in online IDE :/

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana
Copy link
Contributor

poiana commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 21, 2024

/milestone 0.19.0

@poiana poiana added this to the 0.19.0 milestone Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (f74a458) to head (f1e4a3b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2125   +/-   ##
=======================================
  Coverage   74.45%   74.46%           
=======================================
  Files         253      253           
  Lines       33052    33052           
  Branches     5664     5667    +3     
=======================================
+ Hits        24610    24612    +2     
+ Misses       8419     8416    -3     
- Partials       23       24    +1     
Flag Coverage Δ
libsinsp 74.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Perf diff from master - unit tests

     8.49%     -1.66%  [.] sinsp::next
     2.68%     +1.19%  [.] sinsp_thread_manager::get_thread_ref
     0.73%     +0.79%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
    10.30%     -0.67%  [.] sinsp_parser::reset
     2.06%     +0.60%  [.] sinsp_thread_manager::find_thread
     1.85%     +0.60%  [.] sinsp::fetch_next_event
     0.89%     -0.45%  [.] sinsp_fdtable::sinsp_fdtable
     0.67%     +0.42%  [.] scap_event_has_large_payload
     0.17%     +0.42%  [.] copy_and_sanitize_path
     5.64%     -0.42%  [.] sinsp_parser::process_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0225         -0.0225           156           152           156           152
BM_sinsp_split_median                                          -0.0226         -0.0226           156           152           156           152
BM_sinsp_split_stddev                                          +0.2194         +0.2198             1             1             1             1
BM_sinsp_split_cv                                              +0.2474         +0.2478             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0646         -0.0647            62            58            62            58
BM_sinsp_concatenate_paths_relative_path_median                -0.0692         -0.0692            62            58            62            58
BM_sinsp_concatenate_paths_relative_path_stddev                -0.8262         -0.8255             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8142         -0.8134             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0534         +0.0534            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0482         +0.0482            24            25            24            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.5804         +1.5752             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +1.4495         +1.4446             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0876         -0.0876            62            57            62            57
BM_sinsp_concatenate_paths_absolute_path_median                -0.0897         -0.0897            62            57            62            57
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.5823         +1.5802             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.8301         +1.8278             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0226         +0.0226           390           399           390           399
BM_sinsp_split_container_image_median                          +0.0224         +0.0223           390           399           390           399
BM_sinsp_split_container_image_stddev                          +0.0031         +0.0024             2             2             2             2
BM_sinsp_split_container_image_cv                              -0.0191         -0.0198             0             0             0             0

@poiana poiana merged commit 509bec5 into master Oct 21, 2024
49 checks passed
@poiana poiana deleted the fix/create_comment_artifact_check branch October 21, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants