Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver/bpf): fix sys_poll_x verifier bug on fedora 40 #2095

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

albe19029
Copy link
Contributor

@albe19029 albe19029 commented Oct 8, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area driver-bpf

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2094

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(driver/bpf): fix sys_poll_x verifier bug on fedora 40

@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

Welcome @albe19029! It looks like this is your first PR to falcosecurity/libs 🎉

Copy link

github-actions bot commented Oct 8, 2024

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@FedeDP FedeDP changed the title Fix sys_poll_x on fedora 40 fix(driver/bpf): fix sys_poll_x verifier bug on fedora 40 Oct 8, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

Reworked PR body to meet our contributions standards :)
Thanks for the PR!

@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

Running kernel-tests against this PR https://github.com/falcosecurity/libs/actions/runs/11232975504

Copy link

github-actions bot commented Oct 8, 2024

Perf diff from master - unit tests

     6.86%     -0.91%  [.] sinsp_evt::get_type
     2.81%     +0.70%  [.] sinsp_thread_manager::get_thread_ref
     4.78%     -0.69%  [.] next
     0.84%     +0.66%  [.] sinsp_parser::event_cleanup
     1.01%     -0.66%  [.] libsinsp::state::stl_container_table_adapter<std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, libsinsp::state::value_table_entry_adapter<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::dynamic_fields_t>::stl_container_table_adapter
     4.67%     -0.57%  [.] gzfile_read
     0.96%     -0.57%  [.] sinsp_evt::get_direction
     0.45%     +0.56%  [.] scap_next
     0.51%     +0.50%  [.] scap_event_has_large_payload
     1.18%     -0.47%  [.] sinsp_evt::get_param

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0037         +0.0037           153           154           153           154
BM_sinsp_split_median                                          +0.0075         +0.0075           153           154           153           154
BM_sinsp_split_stddev                                          -0.4258         -0.4262             2             1             2             1
BM_sinsp_split_cv                                              -0.4280         -0.4283             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0151         -0.0151            62            61            62            61
BM_sinsp_concatenate_paths_relative_path_median                -0.0111         -0.0111            61            61            61            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.3204         -0.3201             1             1             1             1
BM_sinsp_concatenate_paths_relative_path_cv                    -0.3101         -0.3097             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0164         -0.0164            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0149         -0.0149            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.0768         -0.0762             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.0614         -0.0608             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0587         -0.0587            64            60            64            60
BM_sinsp_concatenate_paths_absolute_path_median                -0.0289         -0.0289            64            62            64            62
BM_sinsp_concatenate_paths_absolute_path_stddev                +4.7154         +4.7160             1             3             1             3
BM_sinsp_concatenate_paths_absolute_path_cv                    +5.0717         +5.0722             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0102         +0.0102           392           396           392           396
BM_sinsp_split_container_image_median                          +0.0098         +0.0097           393           396           393           396
BM_sinsp_split_container_image_stddev                          -0.5228         -0.5228             3             2             3             2
BM_sinsp_split_container_image_cv                              -0.5276         -0.5276             0             0             0             0

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.69%. Comparing base (2b1e402) to head (1bff63a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2095   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files         253      253           
  Lines       31914    31914           
  Branches     5642     5635    -7     
=======================================
+ Hits        23519    23520    +1     
+ Misses       8395     8394    -1     
Flag Coverage Δ
libsinsp 73.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

X64 matrix:

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Arm64 matrix:

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

All green! Thanks!

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

LGTM label has been added.

Git tree hash: d10b2c2a761f578f2a9c915d670e10c94157525b

@poiana poiana added the approved label Oct 8, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

/milestone next-driver

@poiana poiana added this to the next-driver milestone Oct 8, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albe19029, Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Oct 8, 2024

/unhold

@poiana poiana merged commit 973797e into falcosecurity:master Oct 8, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora 40 - libscap: bpf_load_program() event=raw_tracepoint/filler/sys_poll_x: Operation not permitted
4 participants