add new TTL argument + fix settings via envvar and args #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Issif <[email protected]>
fjogeleit
approved these changes
Jun 30, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fjogeleit, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 1f8a8ce3cf8083ca120a1a3aa14ed8ef683637fb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Issif [email protected]
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR allows to set a
TTLfor keys + fix an issue introduced with PR #53, theintsettings were only considered through env vars and not args anymore.Which issue(s) this PR fixes:
#54
Fixes #
Special notes for your reviewer:
I had to fork github.com/Redisearch/redisearch-go to introduce a new command
EXPIRE, I've also submitted a PR. When (if it is...) it will merged in upstream, I will switch back to it.