Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 404 broken links + add a workflow to checks the links #1439

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Issif
Copy link
Member

@Issif Issif commented Jan 21, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind event

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area community

What this PR does / why we need it:

This PR fixes all broken links (404 errors) between the different pages + introduces a new CI job to check the links at every PR to avoid to introduce new broken links

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This PR reproduces the same CI Job we have for the charts https://github.com/falcosecurity/charts/blob/master/.github/workflows/links.yml

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Issif
This is great! Thank you 🙏

Just one issue (see below comment), otherwise SGMT!

.github/workflows/links.yml Outdated Show resolved Hide resolved
@Issif Issif force-pushed the feature/links-check branch from ac22b22 to a2bd9db Compare January 22, 2025 10:11
@poiana poiana added the lgtm label Jan 22, 2025
@poiana
Copy link

poiana commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 22, 2025

LGTM label has been added.

Git tree hash: 7e006ae33d5e7cdaba054454c7c41420558a4ed5

@poiana poiana merged commit 7856d69 into master Jan 22, 2025
7 checks passed
@poiana poiana deleted the feature/links-check branch January 22, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants