Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(typing): restructure typing docs into a separate chapter #2401

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Nov 4, 2024

No description provided.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5c4406c) to head (fc19e61).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2401   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7726      7726           
  Branches      1071      1071           
=========================================
  Hits          7726      7726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion, but it's good also without it

.. important::
This is only a typing limitation that has no effect outside of type
checking -- the above ``app`` will run just fine!

Copy link
Member

@CaselIT CaselIT Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add somewhere in this section that we are working to remove these limitations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll address this in the 4.0.2 microrelease PR then. That's a good suggestion, but I think it would best fit into the sentence just above this note, where we link to the GitHub issue.

@vytas7 vytas7 merged commit ca2e6d9 into falconry:master Nov 4, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants