Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(user): move examples and recipes to Python files #2261

Merged
merged 11 commits into from
Aug 11, 2024
Merged

docs(user): move examples and recipes to Python files #2261

merged 11 commits into from
Aug 11, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Aug 9, 2024 •
edited
Loading

Fixes #44.

@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0c1aca8). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #2261   +/-   ##
=========================================
  Coverage          ?   36.07%           
=========================================
  Files             ?       63           
  Lines             ?     6849           
  Branches          ?     1260           
=========================================
  Hits              ?     2471           
  Misses            ?     4320           
  Partials          ?       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CaselIT
CaselIT reviewed Aug 9, 2024
View reviewed changes
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

examples/recipes/output_csv_stream_asgi.py Show resolved Hide resolved
examples/recipes/request_id_context.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
tests/test_examples.py Show resolved Hide resolved
tests/test_recipes.py Outdated Show resolved Hide resolved
@vytas7
Copy link
Member Author

vytas7 commented Aug 10, 2024

nice work!

Thanks!

@vytas7 vytas7 marked this pull request as ready for review August 10, 2024 06:39
@vytas7 vytas7 merged commit 262129a into falconry:master Aug 11, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaselIT CaselIT CaselIT approved these changes

@nZac nZac Awaiting requested review from nZac

@kgriffs kgriffs Awaiting requested review from kgriffs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add example code & recipes to test suite
2 participants
@vytas7 @CaselIT