Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Last-Modified header for static files #2244

Open
vytas7 opened this issue Jul 13, 2024 · 2 comments
Open

Support Last-Modified header for static files #2244

vytas7 opened this issue Jul 13, 2024 · 2 comments
Labels
enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks!
Milestone
Triaged (Non-Brea...

Comments

@vytas7
Copy link
Member

vytas7 commented Jul 13, 2024 •
edited
Loading

Render the Last-Modified header when serving static files. We are already performing .stat() on the open file handle, so we should have the required modification date.

When serving, also check the If-Modified-Since header, and render HTTP 304 Not Modified if appropriate.

This issue is very similar to #2243, but probably slightly easier, so maybe this one could be taken first.
@vytas7 vytas7 added good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! enhancement needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! europython2024 labels Jul 13, 2024
@TimoHorstmann
Copy link

Trying to sprint on it

@vytas7 vytas7 removed the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Jul 13, 2024
@vytas7 vytas7 added this to the Triaged (Non-Breaking Changes) milestone Aug 10, 2024
@vytas7
Copy link
Member Author

vytas7 commented Aug 27, 2024

@TimoHorstmann just checking, do you have any files left from the Sprint that might be of use?

@vytas7 vytas7 added the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Oct 6, 2024
@vytas7 vytas7 mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks!
Projects
None yet
Milestone
Triaged (Non-Breaking Changes)
Development

No branches or pull requests
2 participants
@vytas7 @TimoHorstmann