Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper HEAD support for static routes #2337

Open
vytas7 opened this issue Sep 22, 2024 · 11 comments
Open

Proper HEAD support for static routes #2337

vytas7 opened this issue Sep 22, 2024 · 11 comments
Labels
enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks!
Milestone

Comments

@vytas7
Copy link
Member

vytas7 commented Sep 22, 2024

Implement proper HEAD support for static file serving.

The response should follow the same logic as the default GET behaviour (like now), but not open any file streams (because we do not need any as the response to a HEAD request cannot have any body anyway).

As a bonus, I think we need to block unsupported methods such as POST and PUT, and render the correct Allow header in response to OPTIONS.

@vytas7 vytas7 added good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks! enhancement needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! labels Sep 22, 2024
@vytas7 vytas7 added this to the Version 4.x milestone Sep 22, 2024
@akashverma0786
Copy link

so, do we need to get the metadata only?

@Aanchallllll
Copy link

Hello,
would like to contribute.can i be assigned?

@vytas7
Copy link
Member Author

vytas7 commented Oct 1, 2024

Hi @Aanchallllll!
Happy to hear you considering to contribute.
We don't specifically assign per se, a comment here is enough to know that you are working on it!

However, as I understand, @akashverma0786 has also expressed interest, could you two coordinate so that we don't end up duplicating efforts? We have otherwise no shortage of issues 😅

@akashverma0786
Copy link

Hi Anchal, Please go ahead with this issue, I will find myself another one, there are lots here . :)

@vytas7 vytas7 removed the needs contributor Comment on this issue if you'd like to volunteer to work on this. Thanks! label Oct 1, 2024
@vytas7
Copy link
Member Author

vytas7 commented Oct 1, 2024

Cool beans, then it sounds like we have a plan. 😅
I've removed the needs contributor label, and we are looking forward to your PR @Aanchallllll 👍

@arthurprioli
Copy link

Hello, I would like to take this issue, where should I start?

@vytas7
Copy link
Member Author

vytas7 commented Oct 7, 2024

Hi @arthurprioli!
@Aanchallllll is already working on this one, could you coordinate with her?

We have otherwise no shortage of issues, we could find you another one 🙂

@arthurprioli
Copy link

No problem! I'm looking for a refactoring like issue just to get me started. I'm using the "good first issues" label to check them out but I'd appreciate any recommendations for simpler issues to help me get started!

@vytas7
Copy link
Member Author

vytas7 commented Oct 9, 2024

I don't think we have good simple refactoring issues atm.
But since you were looking at this one, this one is similar: #2244. And it should be fairly straightforward.

@arthurprioli
Copy link

Thanks for the suggestion! After taking a look I chose #1026 because it seemed more refactoration like, do you think it is a good idea? Thank you for your patience and time!

@vytas7
Copy link
Member Author

vytas7 commented Oct 9, 2024

I would say #1026 and #2244 are roughly similar in complexity, so it is fine if you pick the one you prefer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Comment on this issue if you'd like to volunteer to work on this. Thanks!
Projects
None yet
Development

No branches or pull requests

4 participants