fix: ability to upload the same file after deleting #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
requested changes
Dec 16, 2022
IgorShadurin
force-pushed
the
fix/192-upload-deleted-file-again
branch
from
f73bc81 to
fd584fa
Compare
nugaon
reviewed
Jan 19, 2023
There was a problem hiding this comment.
so if I understand, the problem was the writeFeedDataRaw attempted to write on a reserved index since the next subsequent index was not calculated.
it is quite strange since it should have thrown an error because of writing on a reserved index.
maybe instead of
if (!epoch) {
epoch = new Epoch(HIGHEST_LEVEL, getUnixTimestamp())
}
this snippet should find for the latest free index instead if epoch is not defined
src/file/file.ts
Outdated
Comment on lines
112
to
118
| let nextEpoch | ||
| try { | ||
| const feedData = await getFeedData(connection.bee, fullPath, prepareEthAddress(podWallet.address)) | ||
| feedData.epoch.level = feedData.epoch.getNextLevel(feedData.epoch.time) | ||
| nextEpoch = feedData.epoch | ||
| // eslint-disable-next-line no-empty | ||
| } catch (e) {} |
There was a problem hiding this comment.
maybe this snippet could be moved to writeFeedData to ensure the feed write will happen on the next free index, wdyt?
| @@ -82,5 +82,7 @@ export async function writeFeedDataRaw( | |||
| const id = getId(topicHash, epoch.time, epoch.level) | |||
| const socWriter = connection.bee.makeSOCWriter(privateKey) | |||
|
|
|||
| return socWriter.upload(connection.postageBatchId, id, data) | |||
| return await socWriter.upload(connection.postageBatchId, id, data, { | |||
| pin: true, | |||
There was a problem hiding this comment.
why do you need pinning? we do not require this
IgorShadurin
force-pushed
the
fix/192-upload-deleted-file-again
branch
from
fd584fa to
ad5d959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #192