Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Swish function to enable model export #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaanrockz
Copy link

@shaanrockz shaanrockz commented May 29, 2023

Motivation and Context

SwishFunction is not exportable due to memory efficient implementation using torch.autograd. I have added simplified swish function in eval model to enable export.

Issue: #184

Utilisation (torchscript):

model.eval()
traced_model = torch.jit.trace(model, input)

Utilisation (onnx):

model.eval()
torch.onnx.export(model, input, ......)

Utilisation (tensorRT):

from torch2trt import torch2trt
model.eval()
model_trt = torch2trt(model, ...)

How Has This Been Tested

I have tested the implementation myself, but I have not created a test for it.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2023
@shaanrockz
Copy link
Author

Previous test cases failed. This commit does not have any test cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants