{Feature} C++ - Core - Calibration - unit test for cast in CameraProjection #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68177892 |
Summary: Add template to `class CameraProjection` definition, to support both double and float. The motivation is to enable users to freely choose the underlying data type of the CameraProjection. In order to avoid API change, I added `using CameraProjection = CameraProjectionTemplated<double>;` ModelType and ProjectionVariant are taken from projectaria::tools::calibration::CameraProjection to projectaria::tools::calibration. Reviewed By: YLouWashU, alexander-james-gamino Differential Revision: D67540817
Summary: Add a cast member function to `CameraProjection`: ``` template <typename OtherScalar> CameraProjectionTemplated<OtherScalar> cast() const; ``` Reviewed By: YLouWashU Differential Revision: D68133717
…ection (facebookresearch#180) Summary: Unit test for cast function in CameraProjectionTemplated. Reviewed By: YLouWashU Differential Revision: D68177892
YLouWashU
force-pushed
the
export-D68177892
branch
from
c565447 to
c93d0bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68177892 |
|
This pull request has been merged in 8b84781. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Unit test for cast function in CameraProjectionTemplated.
Reviewed By: YLouWashU
Differential Revision: D68177892